Add tests for converters #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
khuezy
approved these changes
Oct 15, 2024
Contributor
khuezy
left a comment
khuezy
left a comment
There was a problem hiding this comment.
Thanks so much for doing this! When ready, we should add this to the github workflow to run the unit test on PRs (synchronize)
| test: "test", | ||
| }, | ||
| multiValueQueryStringParameters: { | ||
| test: ["test"], |
Contributor
There was a problem hiding this comment.
What happens when the same key (test) has different values? Do we want to merge the two? Is that even possible?
eg:
queryStringParameters: {
test: "test",
},
multiValueQueryStringParameters: {
test: ["test-multi"],
}
Contributor
There was a problem hiding this comment.
I guess it shouldn't be possible, hopefully aws has some kind of validation on this to avoid this kind of case.
Contributor
It already runs on validate right now |
Contributor
|
Ah nice, I didn't realize. |
conico974
approved these changes
Oct 15, 2024
Contributor
conico974
left a comment
conico974
left a comment
There was a problem hiding this comment.
That's very nice thank you.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.