Skip to content
Validate merge requests

refactor: code simplification #727

Sign in to view logs

refactor: code simplification

refactor: code simplification #727

Triggered via pull request November 8, 2024 16:17
@vicbvicb
synchronize #627
misc/refactor
Status Failure
Total duration 1m 0s
Artifacts –

check.yml

on: pull_request
validate
48s
validate
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 10 warnings, and 10 notices
packages/tests-unit/tests/http/utils.test.ts > parseCookies > returns undefined if cookies is empty: packages/tests-unit/tests/http/utils.test.ts#L6
AssertionError: expected [ '' ] to be undefined - Expected: undefined + Received: Array [ "", ] ❯ packages/tests-unit/tests/http/utils.test.ts:6:21
packages/tests-unit/tests/http/utils.test.ts > parseCookies > returns undefined if no cookies: packages/tests-unit/tests/http/utils.test.ts#L10
AssertionError: expected [] to be undefined - Expected: undefined + Received: Array [] ❯ packages/tests-unit/tests/http/utils.test.ts:10:21
validate
tests-unit#test: command (/home/runner/work/opennextjs-aws/opennextjs-aws/packages/tests-unit) pnpm run test exited (1)
validate
Process completed with exit code 1.
lint/style/noUnusedTemplateLiteral: .changeset/aggregate.mjs#L50
Do not use template literals if interpolation and special-character handling are not needed.
lint/style/useSelfClosingElements: examples/app-pages-router/app/albums/@modal/(.)[album]/[song]/page.tsx#L19
JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
lint/style/useSelfClosingElements: examples/app-pages-router/app/albums/[album]/[song]/page.tsx#L17
JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
lint/correctness/useJsxKeyInIterable: examples/app-pages-router/app/albums/page.tsx#L9
Missing key property for this element in iterable.
lint/style/noUselessElse: examples/app-pages-router/middleware.ts#L14
This else clause can be omitted because previous branches break early.
lint/style/noUselessElse: examples/app-pages-router/middleware.ts#L18
This else clause can be omitted because previous branches break early.
lint/style/noUselessElse: examples/app-pages-router/middleware.ts#L25
This else clause can be omitted because previous branches break early.
lint/performance/noDelete: packages/tests-unit/tests/core/routing/util.test.ts#L528
Avoid the delete operator which can impact performance.
lint/complexity/useLiteralKeys: packages/tests-unit/tests/core/routing/util.test.ts#L528
The computed expression can be simplified without the use of a string literal.
lint/style/useSelfClosingElements: examples/app-router/app/albums/@modal/(.)[album]/[song]/page.tsx#L19
JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
lint/suspicious/noExplicitAny: packages/utils/src/logger.ts#L1
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/utils/src/logger.ts#L7
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/utils/src/logger.ts#L11
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/tests-unit/tests/core/routing/util.test.ts#L29
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/tests-unit/tests/core/routing/util.test.ts#L435
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: examples/app-router/app/sse/page.tsx#L6
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/open-next/src/adapters/logger.ts#L7
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/open-next/src/adapters/logger.ts#L13
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/open-next/src/adapters/logger.ts#L47
Unexpected any. Specify a different type.
lint/suspicious/noExplicitAny: packages/open-next/src/adapters/image-optimization-adapter.ts#L100
Unexpected any. Specify a different type.