[cloudflare] Add nextauth infos #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Thanks for the PR @markdembo, I've left some comments as a few things seem a bit off to me 🙂
Contributor
|
PS: also the formatting seems wrong, you can fix it by running |
Co-authored-by: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Contributor
Author
|
Much appreciate the feedback @dario-piotrowicz - applied all requested changes. |
dario-piotrowicz
approved these changes
Mar 6, 2025
Contributor
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Thanks a lot @markdembo for the changes 🫶
Sorry there is one last small missing thing, besides that this is good to go for me 😄
Co-authored-by: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating information from GH issues:
cloudflare/workerd#3277 (comment)
opennextjs/opennextjs-cloudflare#435 (comment)