chore: add formatter #83
Conversation
james-elicx
commented
Feb 25, 2025
james-elicx
commented
- Uses the Prettier config that we have in cloudflare adapter
- Adds an action to run in pipelines
james-elicx
force-pushed
the
james/add-prettier
branch
4 times, most recently
from
9b5315c to
f5c1285
Compare
james-elicx
force-pushed
the
james/add-prettier
branch
from
f5c1285 to
b15bebe
Compare
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
That's something I was desperately missing!
Thanks for taking the time to implement this.
Let's wait for aws approval before merging.
conico974
left a comment
conico974
left a comment
There was a problem hiding this comment.
LGTM Thanks for doing that.
We may want to ask netlify as well
^ @serhalp ? |
serhalp
left a comment
serhalp
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just a question about bun
| "lint": "next lint", | ||
| "prettier:check": "prettier --check .", | ||
| "prettier:fix": "prettier --write .", | ||
| "fix": "bun run prettier:fix" |
There was a problem hiding this comment.
Is this intentional? I don't see bun being used anywhere else, and it isn't installed in local dev (just CI) 🤔
There was a problem hiding this comment.
This repo uses Bun - there's a bun.lockb for managing deps in here. Looking at it, we have both a bun.lockb and package-lock.json, but the ci has always used bun
