-
Notifications
You must be signed in to change notification settings - Fork 46
Update get-started.mdx #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in the bottom how to deploy section it has `deploy:worker` I think this should match.
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dario-piotrowicz what do you think?
C3 template uses deploy.
We should pick either one, maybe :worker everywhere and we update here, c3, and the adapter repo?
@vicb if you look at the PS: Thanks for spotting the issue @codercatdev 🫶 |
|
What I mean is consistency can be 2 two things:
I updated (some of) the docs in #50 to use But now I'm wondering if we shouldn't got the 1 way (in docs + templates) |
my preference as I mentioned is to be consistent with the c3 template (2.) and remove the but again, I'm ok to go with 1. if that's your preference |
Ok, let's do that, which means:
I'll update the adapter to reflect that. |
why |
Because it has been like that since day 1 and probably too similar to |
|
and there is not even a question because |
|
@vicb sorry, I just realized now that I asked my question wrongly, I was asking why we need have
👆 That's exactly what I was saying, there already is a that's exactly what we have in C3, there is no I feel like this is clearer than having anyways if you want to keep |
|
I'm ok to drop dev:worker. |
oh yeah, I didn't consider dropping (actually the C3 template already doesn't have that) sounds good to me 👍 |
|
@codercatdev the change was made in #68. You are a co-author of this change as this was suggested by you. Thanks! |
in the bottom how to deploy section it has
deploy:workerI think this should match.