-
Notifications
You must be signed in to change notification settings - Fork 85
Add support for AIX in build process #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for AIX in build process #297
Conversation
|
👋 Welcome back sroy! A progress list of the required criteria for merging this PR into |
|
@suchismith1993 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
JornVernee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Are you planning on using the MakeFile build? We are currently only using this for Oracle internal CI
build.gradle
Outdated
| environment "CC", "/opt/IBM/xlC/13.1.3/bin/xlc" | ||
| environment "CXX", "/opt/IBM/xlC/13.1.3/bin/xlC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover from testing I presume?
Yes. There was no support for AIX , I had to add the path for libclang.a. |
|
Hi @JornVernee can you kindly review this for further changes ? |
Summary of the issues:
JBS Issue: CODETOOLS-7904116
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/297/head:pull/297$ git checkout pull/297Update a local copy of the PR:
$ git checkout pull/297$ git pull https://git.openjdk.org/jextract.git pull/297/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 297View PR using the GUI difftool:
$ git pr show -t 297Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/297.diff
Using Webrev
Link to Webrev Comment