-
Notifications
You must be signed in to change notification settings - Fork 112
8354469: Keytool exposes the password in plain text when command is piped using | grep #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back nibjen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
/issue JDK-8366261 |
|
@nibjen |
|
The most important test is the newly added manual test |
|
@nibjen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Hi, |
This PR contains both JDK-8354469 and JDK-8366261 since earlier one depends on later fix.
Manually merged ModuleSelectionTest, Console, JdkConsoleImpl for minor conflicts on syntax.
Verified the required tests from tier1-tier3.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/332/head:pull/332$ git checkout pull/332Update a local copy of the PR:
$ git checkout pull/332$ git pull https://git.openjdk.org/jdk25u.git pull/332/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 332View PR using the GUI difftool:
$ git pr show -t 332Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/332.diff
Using Webrev
Link to Webrev Comment