8365065: cancelled ForkJoinPool tasks no longer throw CancellationException

[rm-gh-8]

Backporting JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException. Fixes the exception propagation and tests. Based on the original bug it is a regression and it last worked in version 17.0.16. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/util/concurrent

Results are attached.

linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8365065 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8365065: cancelled ForkJoinPool tasks no longer throw CancellationException

Issue

• JDK-8365065: cancelled ForkJoinPool tasks no longer throw CancellationException (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/3.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[rm-gh-8]

/approval request for backport of JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException.

[openjdk]

@rm-gh-8
8365065: The approval request has been updated successfully.

[mlbridge]

Webrevs

• 00: Full (0e5d93ac)

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Hi @rm-gh-8
Please supply sufficient approval request comments.
Read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix thoroughly please! Expecially 6 ii)
You need to talk about:
*Why you backport. Why should the change go to the update release (No, not because it fixes the bug!)
*The risk of breaking anything, especially running applications that obtain an update.
*Short description of how you backported (clean? trivial edit? other changes included?)
*Clean is only clean if Skara says so!
*Short test overview.
This goes to the JBS issue, it needs to make sense there. If you repeat the title of the bug that's quite pointless.

I will silently remove the fix request labels if the approval comment does not help me to assess the backport. Later, I might just reject them.

[rm-gh-8]

@GoeLin I edited the existing approval comments on the other PRs pending approval.

Before I proceed with this current PR. It is modifying the exception propagation back to be compliant with the specification, but it does make a modification in the javadoc comment. Is expectation to remove the javadoc comment changes from the backport so it just entails behavioral changes?

[rm-gh-8]

/approval request for backport of JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException.

Fixes the exception propagation back to be compliant with the specification, and has customer demand for a fix.

[openjdk]

@rm-gh-8
8365065: The approval request has been updated successfully.