Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 9, 2025

I backport this for parity with 17.0.19-oracle.

Backport of the change in jdk21u-dev.

Resolved two comments in src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java

Nice that it's clean anyways!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336695 needs maintainer approval

Issue

  • JDK-8336695: Update Commons BCEL to Version 6.10.0 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4208/head:pull/4208
$ git checkout pull/4208

Update a local copy of the PR:
$ git checkout pull/4208
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4208

View PR using the GUI difftool:
$ git pr show -t 4208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4208.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336695: Update Commons BCEL to Version 6.10.0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 6ec79e41579e01ad408d71ca75e79ce7f29321db 8336695: Update Commons BCEL to Version 6.10.0 Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 9, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2025

Webrevs

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 11, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Dec 12, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

Going to push as commit 454e260.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2025
@openjdk openjdk bot closed this Dec 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@GoeLin Pushed as commit 454e260.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant