8337795: Type annotation attached to incorrect type during class reading

[cushon]

This is a backport of JDK-8337795, which is a follow-up to JDK-8341779.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8337795 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337795: Type annotation attached to incorrect type during class reading (Bug - P3 - Requested)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer) 🔄 Re-review required (review applies to 54175e13)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4149/head:pull/4149
$ git checkout pull/4149

Update a local copy of the PR:
$ git checkout pull/4149
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4149

View PR using the GUI difftool:
$ git pr show -t 4149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4149.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/4124 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full (0028bbfc)
• 02: Full (54175e13)
• 01: Full - Incremental (e9f01f43)
• 00: Full (06a5a17f)

[openjdk]

@cushon Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @cushon This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@cushon Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[bridgekeeper]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[cushon]

/touch

[openjdk]

@cushon The pull request is being re-evaluated and the inactivity timeout has been reset.

[vicente-romero-oracle]

lgtm

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8337795
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@cushon this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8337795
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @cushon This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[cushon]

/approval request for backport. This is a follow-on fix related to JDK-8341779.

[openjdk]

@cushon
8337795: The approval request has been created successfully.