8282484: G1: Predicted old time in log always zero

[jyma22]

Hi all,

This pull request contains a backport of commit d4d1fbc2 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on Mar 3, 2022 and was reviewed by Albert Mingkun Yang and Ivan Walulya.

This PR depends on pr/3992, so the target would be changed from pr/3992 to master once pr/3992 is approved and merged.

Testing: jtreg 1-3 gha

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8282484 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8282484: G1: Predicted old time in log always zero (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3993/head:pull/3993
$ git checkout pull/3993

Update a local copy of the PR:
$ git checkout pull/3993
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3993

View PR using the GUI difftool:
$ git pr show -t 3993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3993.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @jyma22, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jyma22" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[jyma22]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[jyma22]

/approval request fixes log output for the amount of expected time the initial set of old gen regions is going to take

[openjdk]

@jyma22
8282484: The approval request has been created successfully.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (6fbbf23f)
• 01: Full - Incremental (ccb7e453)
• 00: Full (ccb7e453)

[jyma22]

This backport itself was clean, but it was built on unapproved changes on PR #3992.

[jyma22]

Fix Request 17u

Backporting this patch fixes the log output to accurately report the expected time required to process the initial set of old gen regions.
Path applies cleanly to 17u, but requires JDK-8306444 to be applied first through pr/3992.
Included test passes. Ran tier1-3.

[jyma22]

/approval request Backporting this patch fixes the log output to accurately report the expected time required to process the initial set of old gen regions.
Path applies cleanly to 17u, but requires JDK-8306444 to be applied first through pr/3992.
Included test passes. Ran tier1-3.

[openjdk]

@jyma22
8282484: Approval has already been requested and approved.