-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371920: [TEST] Enable CMove tests on other platforms #28702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8371920: [TEST] Enable CMove tests on other platforms #28702
Conversation
|
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Hi,
Can you help to review this patch?
JDK-8357551 add support of CMoveF/D vectorization, at the same time it also adds some tests for scalar CMove on riscv.
It's good to enable these tests on other platforms, like x86/aarch64 or maybe others.
At the same time, this pr also move these tests under
compiler/c2/cmove, as suggested here #28309 (comment).Thanks!
Test
In progress... (I'm using github CI to run the tests.)
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28702/head:pull/28702$ git checkout pull/28702Update a local copy of the PR:
$ git checkout pull/28702$ git pull https://git.openjdk.org/jdk.git pull/28702/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28702View PR using the GUI difftool:
$ git pr show -t 28702Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28702.diff
Using Webrev
Link to Webrev Comment