Skip to content

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Dec 8, 2025

Hi,
Can you help to review this patch?

JDK-8357551 add support of CMoveF/D vectorization, at the same time it also adds some tests for scalar CMove on riscv.
It's good to enable these tests on other platforms, like x86/aarch64 or maybe others.

At the same time, this pr also move these tests under compiler/c2/cmove, as suggested here #28309 (comment).

Thanks!

Test

In progress... (I'm using github CI to run the tests.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371920: [TEST] Enable CMove tests on other platforms (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28702/head:pull/28702
$ git checkout pull/28702

Update a local copy of the PR:
$ git checkout pull/28702
$ git pull https://git.openjdk.org/jdk.git pull/28702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28702

View PR using the GUI difftool:
$ git pr show -t 28702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28702.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@Hamlin-Li Hamlin-Li changed the title 8371920: [TEST] Enable scalar CMove tests on other platforms 8371920: [TEST] Enable CMove tests on other platforms Dec 8, 2025
@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant