Skip to content

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Dec 8, 2025

Test is intended to run with a small new size, -Xmn8m
Without this, a larger new gen size means the allocations it make continually may never cause the Notification the test is waiting for. Timeout interacts with the process and means some allocation, which does hit the threshold, so we see "Test passed." and a timeout in the same log.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373111: Test java/lang/management/MemoryMXBean/MemoryManagement.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28697/head:pull/28697
$ git checkout pull/28697

Update a local copy of the PR:
$ git checkout pull/28697
$ git pull https://git.openjdk.org/jdk.git pull/28697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28697

View PR using the GUI difftool:
$ git pr show -t 28697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28697.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373111: Test java/lang/management/MemoryMXBean/MemoryManagement.java timed out

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 130 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@kevinjwalls The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@kevinjwalls
Copy link
Contributor Author

/label remove core-libs

@kevinjwalls kevinjwalls marked this pull request as ready for review December 8, 2025 11:39
@openjdk openjdk bot added rfr Pull request is ready for review and removed core-libs core-libs-dev@openjdk.org labels Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@kevinjwalls
The core-libs label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants