Skip to content

Fix predictable SAM hit patterns #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scamiv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix predictable SAM hit patterns #2532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/core/execution/SAMLauncherExecution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ export class SAMLauncherExecution implements Execution {
this.player = this.sam.owner();
}

this.pseudoRandom ??= new PseudoRandom(this.sam.id());

const mirvWarheadTargets = this.mg.nearbyUnits(
this.sam.tile(),
this.MIRVWarheadSearchRadius,
Expand Down Expand Up @@ -279,6 +277,15 @@ export class SAMLauncherExecution implements Execution {
? UnitType.MIRVWarhead
: target?.unit.type();
if (type === undefined) throw new Error("Unknown unit type");

// Seed random with ticks + sam ID + target ID for less predictable results
const targetId =
mirvWarheadTargets.length > 0
? mirvWarheadTargets[0].unit.id()
: target!.unit.id();
this.pseudoRandom ??= new PseudoRandom(
this.mg.ticks() + this.sam.id() + targetId,
);
const random = this.pseudoRandom.next();
const hit = this.isHit(type, random);
if (!hit) {
Expand Down
Loading