-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore: EventBrite updates #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…'t crash on addresses without a newline. Signed-off-by: Jeffrey Belt <jeffrey@theshifters.ch>
|
Converting to draft while I address some other issues. |
The class starting with `Location-module__addressWrapper___` contains the full address rather than just the address "title" which is the address line.
|
I could reproduce the issues mentioned in the first post. |
|
The issues are fixed in my |
Signed-off-by: Jeffrey Belt <jeffrey@theshifters.ch>
|
I tried running the updated scraper on french events and got the following error: Maybe we should use a fallback? |
|
It should be noted that |
Signed-off-by: Jeffrey Belt <jeffrey@theshifters.ch>
|
Taking a look! Working notes:
I'll fix it by Monday. |
EventBrite events have two locations, a "short" one at the top and a full one with address and a lot more text like routing directions at the bottom. The elements and therefore the CSS selectors vary depending on the event being offline (just text) or online (link to another element on the page). The scraper now detects whether an element is online by searching for the short location (CSS selector `span.start-date-and-location__location`) which is present in both cases. The scraper also doesn't crash if it expects an offline element and cannot find the full location. Instead, it logs an error and continues to the next event. This can happen when the scraper doesn't detect that the event is online. Signed-off-by: Jeffrey Belt <jeffrey@theshifters.ch>
Signed-off-by: Jeffrey Belt <jeffrey@theshifters.ch>
|
Fixed in the branch. I have to postpone adding support for a new kind of EventBrite collection (issue #79). I also added a couple more date & time fixes (issue #75). I'm unable to complete a 2tonnes run for France. I never was: something almost always times out after running for dozens of minutes. But the log until then looks good. |
|
Thank you very much @Obersand, I could run the scraper on french events 👍 |
Update to new EventBrite tags:
p.location-info__address-text→span.start-date-and-location__locationdiv.location-info__address→.start-date-and-location__locationdiv.eds-text--left→div.event-descriptionScrape new EventBrite date format, leveraging the
datetimeatrribute for thetimeelement when set.Don't crash on addresses without a newline.