fix(tests): updated redocly openapi schema location #2522
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
|
sacha-c
force-pushed
the
fix-redocly-test-location
branch
from
7c6a67e to
7630111
Compare
Redocly refactored their tests folder structure in Redocly/redocly-cli@cf26d60 And fixed a typo in their schemas in Redocly/redocly-cli@13e753a
sacha-c
force-pushed
the
fix-redocly-test-location
branch
from
7630111 to
53ae0a4
Compare
sacha-c
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the location of the redocly openapi schema used in tests.
Redocly recently refactored their test folder structure in chore: refactor tests and the openapi schema now lives here
I changed the url used in the tests to refer to the specific commit of the file, so these kind of test failures will not happen again even if they do further folder structure refactors.
Additionally they fixed some typos in this commit, which led me to fix a few test files which depended on the typo
In general I think it would be better to avoid depending on an external resource in tests (thus not using a schema in Redocly but rather one defined in this very repository)
The problem is that somehow setting up schema in this repository which could be used equally in local tests & in github actions seemed a little out-of-scope for this fix, but perhaps this could be an improvement to think of for the future, although hopefully Redocly doesn't refactor their test suite very frequently 😉
How to Review
Checking that tests now pass (as opposed to PRs made in the last ~week)
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)