fix: exec-server should drop oversized env vars when escalating #7644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to introduce an integration test for the `codex-shell-tool-mcp` in #7617, macOS CI hit serde decode errors in the escalation pipe when huge env vars inflated the `EscalateRequest` payload past the stream frame, corrupting JSON. (I'm pretty sure `$GITHUB_EVENT` was the offending env var.) This PR updates `exec-server` to filter out oversized env entries and skip reserved vars before serialization. It also updates the code to avoid attaching empty `SCM_RIGHTS` control messages so frames stay lean when no FDs are sent.
Collaborator
Author
|
This did not turn out to be the right fix. Went with #7654 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to introduce an integration test for the
codex-shell-tool-mcpin#7617, macOS CI hit serde decode errors in
the escalation pipe when huge env vars inflated the
EscalateRequestpayloadpast the stream frame, corrupting JSON. (I'm pretty sure
$GITHUB_EVENTwas theoffending env var.)
This PR updates
exec-serverto filter out oversized env entries and skipreserved vars before serialization.
It also updates the code to avoid attaching empty
SCM_RIGHTScontrol messagesso frames stay lean when no FDs are sent.