-
Notifications
You must be signed in to change notification settings - Fork 796
WEB-432-refactor(templates): align view template page with consistent UI pattern #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
shubhamkumar9199
wants to merge
1
commit into
openMF:dev
from
shubhamkumar9199:refactor/template-view-css-global-styles
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
28 changes: 12 additions & 16 deletions
28
src/app/templates/view-template/view-template.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 39 additions & 5 deletions
44
src/app/templates/view-template/view-template.component.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,44 @@ | ||
| // Component-specific styles - minimal overrides to global styles | ||
| // Follows existing patterns from general-tab components | ||
|
|
||
| .container { | ||
| max-width: 37rem; | ||
| max-width: 32rem; | ||
| margin: 0 auto; | ||
| width: 85%; | ||
| } | ||
|
|
||
| mat-card { | ||
| mat-card-content { | ||
| padding: 1.5rem; | ||
|
|
||
| .layout-row-wrap { | ||
| display: grid; | ||
| grid-template-columns: 50% 50%; | ||
|
|
||
| @media (width <= 768px) { | ||
| grid-template-columns: 100%; | ||
| } | ||
| } | ||
|
|
||
| .flex-50 { | ||
| padding: 0.625rem 0; | ||
| display: flex; | ||
| align-items: center; | ||
| font-size: 0.875rem; | ||
| overflow-wrap: break-word; | ||
| line-height: 1.6; | ||
|
|
||
| &.mat-body-strong { | ||
| font-weight: 600; | ||
| } | ||
|
|
||
| &:not(:last-child, :nth-last-child(2)) { | ||
| border-bottom: 1px solid #ddd; | ||
| } | ||
| } | ||
|
|
||
| .content { | ||
| div { | ||
| margin: 1rem 0; | ||
| word-wrap: break-word; | ||
| @media (width <= 480px) { | ||
| padding: 1rem; | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this, but I think If we want to have this line, we should add in all the similar views, my suggestion is to remove and keep the same style with the other views.