Skip to content

Conversation

@AnvayKharb
Copy link
Contributor

@AnvayKharb AnvayKharb commented Nov 23, 2025

Implemented proper handling for the previously non-functional “Forgot Password” button by removing the console.log TODO placeholder and adding a clear, user-friendly response indicating that the feature is not yet available. Also reviewed and cleaned up other unimplemented login-related UI actions to remove TODO logs, reduce tech debt, and prevent misleading or inactive buttons. This ensures a polished user experience and guarantees that all visible actions in the login flow now provide intentional and meaningful behavior.

Screenshots

N/A

Issue Number

WEB-430

Summary by CodeRabbit

  • Bug Fixes
    • Removed the "Forgot Password" button from the login form. This streamlines the login interface by eliminating the previously unavailable password recovery option.

✏️ Tip: You can customize this high-level summary in your review settings.

- Remove 'Forgot Password' button from login form (no backend support)
- Remove forgotPassword() method that only logged to console
- Remove TODO comment about forgot password decision
- Clean up login form layout and method spacing

This eliminates dead UI elements and improves UX by not showing
features that aren't actually available. The button can be added
back when password reset functionality is implemented in the backend.

Resolves WEB-430
@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Removed the Forgot Password feature from the login component by eliminating the associated UI button in the login form template, removing the forgotPassword() and createLoginForm() methods from the component logic, and removing the feature label from the login template.

Changes

Cohort / File(s) Change Summary
Forgot Password feature removal
src/app/login/login-form/login-form.component.html
Removed Forgot Password button block that invoked the forgotPassword() method.
Form component logic cleanup
src/app/login/login-form/login-form.component.ts
Removed public forgotPassword() method and private createLoginForm() method responsible for form initialization.
Login template label removal
src/app/login/login.component.html
Removed "Forgot Password (TODO: Decision to be taken on providing this feature.)" label from the Type of Form section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that the removal of createLoginForm() does not impact form initialization elsewhere in the component or parent component lifecycle.
  • Confirm no other components or services depend on the removed forgotPassword() method.
  • Ensure the login form is still properly instantiated after the removal of its dedicated builder method.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title 'WEB-430: Fix Dead "Forgot Password" Button and Replace TODO Handlers' accurately describes the main changes: removing the non-functional Forgot Password button and eliminating TODO-related code from the login components.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AnvayKharb AnvayKharb marked this pull request as ready for review November 23, 2025 12:48
@AnvayKharb AnvayKharb changed the title WEB-429: Implement Centralized ErrorHandlerService for User-Friendly API Error Messaging WEB-430: Fix Dead “Forgot Password” Button and Replace TODO Handlers Nov 25, 2025
Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit fe49b28 into openMF:dev Nov 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants