Skip to content

Fix the type hint of _metrics_data within InMemoryMetricReader #4837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix the type hint of _metrics_data within InMemoryMetricReader #4837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b9feb9
Fix the type hint of _metrics_data within InMemoryMetricReader
phillipuniverse Dec 3, 2025
604440a
Add CHANGELOG entry
phillipuniverse Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

- `opentelemetry-sdk` - Fix the type hint of the `_metrics_data` property to allow `None` ([#4837](https://github.com/open-telemetry/opentelemetry-python/pull/4837)

## Version 1.39.0/0.60b0 (2025-12-03)

- `opentelemetry-api`: Convert objects of any type other than AnyValue in attributes to string to be exportable
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ def __init__(
preferred_aggregation=preferred_aggregation,
)
self._lock = RLock()
self._metrics_data: MetricsData = None
self._metrics_data: MetricsData | None = None

def get_metrics_data(
self,
Expand Down