-
Notifications
You must be signed in to change notification settings - Fork 769
feat: implement on ending in span processor #4775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
95797e2 to
41c988d
Compare
708f178 to
e64ce23
Compare
|
Has this PR been abandoned or does more work need to be done on it? I'm looking for exactly this functionality so hope it comes soon. |
|
Not abandoned, just struggling to get eyes on it for review. Asked on the #otel-python slack but no luck. |
|
Hi @xrmx, could I get some help getting this reviewed? Thanks |
|
@majanjua-amzn Please fix |
b0e9ab9 to
29ad5c4
Compare
Wasn't able to run the command locally but this should've fixed it @xrmx |
| - feat: implement on ending in span processor | ||
| ([#4775](https://github.com/open-telemetry/opentelemetry-python/pull/4775)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this could go to bottom of Unreleased list for chronological order
|
@xrmx workflows passing and got some approvals, could you get to merge the PR? Thanks in advance! |
Description
SpanProcessor.onEnding() Specification
This PR serves to implement the in-development feature
onEndingfor the span processor. This will allow users to make modifications to the span before it becomes immutable whenonEndis reached.Also updated SimpleSpanProcessor and BatchSpanProcessor to explicitly implement and
passthe_on_endingmethodLoosely following implementation in Java repo: open-telemetry/opentelemetry-java#6367
Fixes: N/A
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
onEndingonStartandonEnd)Span.End())Does This PR Require a Contrib Repo Change?
No.
Checklist: