Skip to content

Fix public symbol checker flaky case #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 2 commits into from
Mar 29, 2024
Merged

Fix public symbol checker flaky case #3825

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
052ac4b
Fix public symbol checker flaky case
aabmass Mar 29, 2024
c189bbc
fix lint
aabmass Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions scripts/public_symbols_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,11 @@ def remove_common_symbols():
if not removed_symbols[file_path]:
del removed_symbols[file_path]

# If a symbol is added and removed in the same commit, we consider it as not
# added or removed.
remove_common_symbols()

if added_symbols or removed_symbols:

# If a symbol is added and removed in the same commit, we consider it
# as not added or removed.
remove_common_symbols()
print("The code in this branch adds the following public symbols:")
print()
for file_path_, symbols_ in added_symbols.items():
Expand Down