opentelemetry-instrumentation-aiohttp-client: add type checking support #4006
+230
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _set_http_peer_port_client, | ||
| _set_http_url, | ||
| _set_status, | ||
| _set_http_host_client, # type: ignore[reportUnknownVariableType] |
Contributor
There was a problem hiding this comment.
Could we avoid adding these ignore if opentelemetry.instrumentation._semconv had more type hints added to it first?
Contributor
Author
There was a problem hiding this comment.
I initially wanted to scope the changes just to aiohttp-client, but I can certainly add typing here too to address the point you're making
Contributor
Author
There was a problem hiding this comment.
Updated all the typing inside opentelemetry.instrumentation._semconv :)
Contributor
There was a problem hiding this comment.
Thanks, and sorry for scope creep. I figured it would help for the other instrumentors later that also use _semconv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add type checking support for the
opentelemetry-aiohttp-clientpackage.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e typecheckDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.