Skip to content

Conversation

@tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Nov 29, 2025

Description

Adds HTTP semantic convention stability migration / opt-in for opentelemetry-instrumentation-pyramid

Fixes #3983

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added unit test
  • Instrumentation with Pyramid test app with opt-in as default, http, and http/dup

Default span attributes

-> http.method: Str(GET)
-> http.server_name: Str(waitress.invalid)
-> http.scheme: Str(http)
-> net.host.name: Str(localhost:8080)
-> http.host: Str(localhost:8080)
-> net.host.port: Int(8080)
-> http.target: Str(/latency/)
-> net.peer.ip: Str(127.0.0.1)
-> net.peer.port: Int(51713)
-> http.user_agent: Str(curl/8.17.0)
-> http.flavor: Str(1.1)
-> http.route: Str(/latency/)
-> http.status_code: Int(200)

http span attributes

-> http.request.method: Str(GET)
-> url.scheme: Str(http)
-> server.address: Str(0.0.0.0)
-> server.port: Int(8080)
-> url.path: Str(/latency/)
-> user_agent.original: Str(curl/8.17.0)
-> network.protocol.version: Str(1.1)
-> http.response.status_code: Int(200)

http/dup has both sets.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review December 2, 2025 00:27
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner December 2, 2025 00:27
Copy link

@JWinermaSplunk JWinermaSplunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, out of curiosity, why are the old histograms measured in milliseconds while the new histograms use seconds?

@tammy-baylis-swi
Copy link
Contributor Author

tammy-baylis-swi commented Dec 5, 2025

why are the old histograms measured in milliseconds while the new histograms use seconds?

Thanks! Good question. The new semconv is definitely in seconds. The old histogram's milliseconds for this instrumentor were introduced a while ago (Aug 2022) and haven't changed since then -- I don't want to change it in this PR either. I'm guessing it predates either the semconv introduction of http.server.duration or its units as seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

opentelemetry-instrumentation-pyramid: HTTP semantic convention stability migration

3 participants