-
Notifications
You must be signed in to change notification settings - Fork 826
build: relax wrapt version constraint in pyproject.toml #3930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Atry
wants to merge
1
commit into
open-telemetry:main
Choose a base branch
from
Atry:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
We have to update all the entries, not just opentelemetry-instrumentation: |
Author
|
@xrmx Updated. Would you mind reviewing it again? |
Update all pyproject.toml files that had "wrapt >= 1.0.0, < 2.0.0" constraint to "wrapt >= 1.0.0, < 3.0.0" to allow wrapt 2.x. Updated packages: - opentelemetry-instrumentation - opentelemetry-processor-baggage - 20 instrumentation packages Also update uv.lock to use wrapt 2.0.1 for CI testing. This change only affects the development lockfile used for testing. End users are not affected as the version constraint allows both wrapt 1.x and 2.x - users can continue using whichever version their package manager resolves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relax the
wraptversion constraint from< 2.0.0to< 3.0.0to allow compatibility with wrapt 2.x.Background
The current constraint
wrapt >= 1.0.0, < 2.0.0unnecessarily prevents users from using wrapt 2.x. This is an unnecessary limitation because the APIs used byopentelemetry-instrumentation(wrap_function_wrapperandObjectProxy) remain compatible in wrapt 2.x.Changes
Updated the wrapt version constraint in the following packages:
opentelemetry-instrumentationopentelemetry-processor-baggageopentelemetry-instrumentation-aio-pikaopentelemetry-instrumentation-aiohttp-clientopentelemetry-instrumentation-aiohttp-serveropentelemetry-instrumentation-aiopgopentelemetry-instrumentation-asyncioopentelemetry-instrumentation-boto3sqsopentelemetry-instrumentation-cassandraopentelemetry-instrumentation-clickopentelemetry-instrumentation-confluent-kafkaopentelemetry-instrumentation-dbapiopentelemetry-instrumentation-elasticsearchopentelemetry-instrumentation-grpcopentelemetry-instrumentation-httpxopentelemetry-instrumentation-jinja2opentelemetry-instrumentation-pikaopentelemetry-instrumentation-pymemcacheopentelemetry-instrumentation-pyramidopentelemetry-instrumentation-threadingopentelemetry-instrumentation-urllib3Type of change
How Has This Been Tested?
uv lock --checkpasses (the locked wrapt version inuv.lockremains unchanged)Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.