fix(instrumentation-ioredis): correctly mark MULTI/PIPELINE in operation name #3278
+78
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
changed the title
aryamohanan
force-pushed
the
fix-ioredis-multi-command
branch
from
e9276f8 to
96ccbb5
Compare
aryamohanan
force-pushed
the
fix-ioredis-multi-command
branch
from
96ccbb5 to
714043c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #3082.
The instrumentation was using older semantic conventions and did not populate
db.operation.name.Additionally, commands in MULTI/EXEC and pipeline were not identified correctly
Short description of the changes
db.operation.namewhen the latest semantic conventions are enabled.MULTIandPIPELINEprefixes for commands executed in transactions or pipelines.