feat(instrumentations-tedious): support net.* and database semconv migration
#3273
+208
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migration This adds support for using `OTEL_SEMCONV_STABILITY_OPT_IN` for controlled migration to stable `net.*` and `db.*` semconv. The `net.*` attributes are controlled by the `http[/dup]` token in `OTEL_SEMCONV_STABILITY_OPT_IN` (as [discussed here](open-telemetry/opentelemetry-js#5663 (comment))) and `db.*` with the `database[/dup]` token. Refs: open-telemetry/opentelemetry-js#5663 Refs: open-telemetry#2953
github-actions
bot
added
pkg:instrumentation-tedious
pkg-status:unmaintained
trentm
added
the
has:sponsor
trentm
commented
Dec 4, 2025
| import type { Connection } from 'tedious'; | ||
| import * as semver from 'semver'; | ||
| // XXX has prettier config stopped working in linting? | ||
| import { ATTR_DB_COLLECTION_NAME, ATTR_DB_NAMESPACE, ATTR_DB_QUERY_TEXT, ATTR_DB_SYSTEM_NAME, ATTR_SERVER_ADDRESS, ATTR_SERVER_PORT, DB_SYSTEM_NAME_VALUE_MICROSOFT_SQL_SERVER } from '@opentelemetry/semantic-conventions'; |
Contributor
Author
There was a problem hiding this comment.
So... has prettier stopped being applied in linting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using
OTEL_SEMCONV_STABILITY_OPT_INfor controlled migration to stablenet.*anddb.*semconv. Thenet.*attributes are controlled by thehttp[/dup]token inOTEL_SEMCONV_STABILITY_OPT_IN(as discussed here) anddb.*with thedatabase[/dup]token.Refs: open-telemetry/opentelemetry-js#5663
Refs: #2953