Feature/db statement sanitizer #3554 #3555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:instrumentation.entityframeworkcore
Member
martincostello
left a comment
martincostello
left a comment
There was a problem hiding this comment.
Just skim-read at this stage. Will review properly if we decide we do want to implement this functionality.
src/OpenTelemetry.Instrumentation.SqlClient/SqlClientTraceInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
alexander-kucherov
force-pushed
the
feature/db-statement-sanitizer
branch
from
8c3b204 to
f4c711b
Compare
...etry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Author
|
@martincostello just a gentle ping to see if you could review this PR when it’s convenient. |
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for #3554 3554
Changes
Introduce a configurable "db-statement sanitizer" option for .NET database instrumentations and connect it to the existing
sanitizeQueryparameter:Add a public configuration option, for example on the relevant instrumentation options type(s), such as:
Wire this option into the code path that calls
ApplyConventionsForQueryText, passingsanitizeQuery: options.DbStatementSanitizerEnabled.Keep
DbStatementSanitizerEnableddefaulting totrueto preserve the current safe-by-default behavior and stay consistent with the OpenTelemetry guidance thatdb.statementshould generally be sanitized by default.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes