Added AWS SDK Changes to support Bedrock spans and Application Signals #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.aws
vastin
reviewed
Oct 30, 2025
src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSServiceHelper.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSServiceHelper.cs
Outdated
Show resolved
Hide resolved
vastin
approved these changes
Nov 11, 2025
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Member
|
@normj, @muhammad-othman, @srprash, do you have a plan to review to should we close this PR? |
Member
muhammad-othman
left a comment
muhammad-othman
left a comment
There was a problem hiding this comment.
Sorry for the late review, somehow I missed it :(
| <ItemGroup> | ||
| <PackageReference Include="AWSSDK.Core" VersionOverride="[4.0.0, 5.0.0)" /> | ||
| <PackageReference Include="AWSSDK.SimpleNotificationService" VersionOverride="[4.0.0, 5.0.0)" /> | ||
| <PackageReference Include="AWSSDK.BedrockRuntime" VersionOverride="[4.0.0, 5.0.0)" /> |
Member
There was a problem hiding this comment.
Why do we need AWSSDK.BedrockRuntime dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added changes to detect bedrock spans and populate attributes accordingly. Also added logic to populate aws specific attributes used by AWS Application Signals like "aws.region", "aws.service", "aws.operation", "aws.requestId", etc. We are currently using our own fork of Opentelemetry-Instrumentation-AWS here: https://github.com/aws-observability/aws-otel-dotnet-instrumentation/tree/main/src/OpenTelemetry.Instrumentation.AWS. This change syncs our local fork so that we can stop relying on it and instead reference this directly instead.
I did some manual testing and was able to verify that the spans created contain the required information.
This PR builds on top of this PR: #2458. The old PR went stale especially after moving from AWS SDK v3 to v4. Most of the comments there have been addressed and most of the semconvs used here are now merged in the semconv pkg.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes