ci(go-feature-flag): Fix flaky maven generate-resources stage #1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-flaky-maven-goff
branch
from
9a370ac to
61c567c
Compare
Member
|
Seeing some issue with this in the CI: |
Member
Author
|
Yes I was in rush and I did not finish it. |
thomaspoignant
force-pushed
the
fix-flaky-maven-goff
branch
4 times, most recently
from
66f1c93 to
e86bf92
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-flaky-maven-goff
branch
from
e86bf92 to
f4cdae7
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-flaky-maven-goff
branch
from
02536eb to
300b7b6
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-flaky-maven-goff
branch
from
410408b to
6dab1a7
Compare
thomaspoignant
commented
Jul 22, 2025
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Member
Author
|
@toddbaert I am good with the PR now if you want to check. |
aepfli
reviewed
Jul 22, 2025
aepfli
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR fixes a flacky generate-resources stage by using a git submodule instead of downloading it from maven.
Related Issues
Fixes #1540