Skip to content

feat: allowing null/missing default values #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aepfli merged 5 commits into from
Jul 28, 2025
Merged

feat: allowing null/missing default values #1511

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
877f251
feat!: allowing null/missing default values
Rahul-Baradol Jul 11, 2025
3b8fbe8
Merge branch 'main' into optional-default-value
aepfli Jul 15, 2025
f2763a0
Merge branch 'main' into optional-default-value
aepfli Jul 23, 2025
1da834f
fixup: activating e2e tests for no-default
aepfli Jul 23, 2025
2fab4e3
fix: variant existence logic for no default value
Rahul-Baradol Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import dev.openfeature.sdk.ProviderEvent;
import dev.openfeature.sdk.Reason;
import dev.openfeature.sdk.Value;
import dev.openfeature.sdk.exceptions.FlagNotFoundError;
import dev.openfeature.sdk.exceptions.GeneralError;
import dev.openfeature.sdk.exceptions.ParseError;
import dev.openfeature.sdk.exceptions.TypeMismatchError;
Expand Down Expand Up @@ -204,6 +205,12 @@ private <T> ProviderEvaluation<T> resolve(Class<T> type, String key, EvaluationC
// check variant existence
Object value = flag.getVariants().get(resolvedVariant);
if (value == null) {
if (resolvedVariant.isEmpty()) {
String message = String.format("no default variant found in flag with key %s", key);
log.debug(message);
throw new FlagNotFoundError(message);
}

String message = String.format("variant %s not found in flag with key %s", resolvedVariant, key);
log.debug(message);
throw new GeneralError(message);
Expand Down
2 changes: 1 addition & 1 deletion ...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
@ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "dev.openfeature.contrib.providers.flagd.e2e.steps")
@ConfigurationParameter(key = OBJECT_FACTORY_PROPERTY_NAME, value = "io.cucumber.picocontainer.PicoFactory")
@IncludeTags("in-process")
@ExcludeTags({"unixsocket", "targetURI", "no-default"})
@ExcludeTags({"unixsocket", "targetURI"})
@Testcontainers
@Isolated
public class RunInProcessTest {
Expand Down