fix: Fix the Sysman Engine Test for the workload submission #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If engine utilization prior to workload submission is above 5%, the check for the utilization values before and after workload should be skipped. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test in the Sysman Engine conformance tests by adding a pre-check for engine utilization. If the engine utilization is already above 5% before workload submission, the test skips validation of before/after utilization values to avoid false failures caused by pre-existing workload on the engine.
Key changes:
- Adds a conditional check to skip workload validation when pre-utilization exceeds 5%
- Logs a descriptive message when the test is skipped due to high pre-utilization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conformance_tests/sysman/test_sysman_engine/src/test_sysman_engine.cpp
Outdated
Show resolved
Hide resolved
If engine utilization prior to workload submission exceeds 5%, the check for the utilization values before and after workload should be skipped. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
Modified the engine workload test to poll pre-utilization for 5 seconds. The test now continuously measures utilization at 500ms intervals over a 5-second period and only skips the workload test if the final pre-utilization value exceeds 5%. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
Modified the engine workload test to poll pre-utilization for 5 seconds. The test now continuously measures utilization at 500ms intervals over a 5-second period and only skips the workload test if the final pre-utilization value exceeds 5%. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
conformance_tests/sysman/test_sysman_engine/src/test_sysman_engine.cpp
Outdated
Show resolved
Hide resolved
Modified the engine workload test to poll pre-utilization for 5 seconds. The test now continuously measures utilization at 500ms intervals over a 5-second period and only skips the workload test if the final pre-utilization value exceeds 5%. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
Modified the engine workload test to poll pre-utilization for 5 seconds. The test now continuously measures utilization at 500ms intervals over a 5-second period and only skips the workload test if the final pre-utilization value exceeds 5%. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
Modified the engine workload test to poll pre-utilization for 5 seconds. The test now continuously measures utilization at 500ms intervals over a 5-second period and only skips the workload test if the final pre-utilization value exceeds 5%. Related-To: NEO-16864 Signed-off-by: Pratik Bari <pratik.bari@intel.com>
joshuaranjan
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the engine workload test to poll pre-utilization for 5 seconds. The test now continuously measures utilization at 500ms intervals over a 5-second period and only skips the workload test if the final pre-utilization value exceeds 5%.
Related-To: NEO-16864
Signed-off-by: Pratik Bari pratik.bari@intel.com