Skip to content

Conversation

@anmonteiro
Copy link
Contributor

CHANGES:

  • fix(core): catch file not found error when finding location snippet #1673
    • Fixes a regression introduced in #1457 that broke builds in the Dune sandbox.

@anmonteiro anmonteiro force-pushed the release-melange-6.0.1 branch from f5c7e66 to ade7feb Compare December 6, 2025 06:36
@anmonteiro
Copy link
Contributor Author

@mseri thank you! I just added these upper bounds.

@anmonteiro
Copy link
Contributor Author

I believe failures seem unrelated now.

…ason-react.0.3.1/opam


```
#=== ERROR while compiling server-reason-react.0.3.1 ==========================#
# context              2.5.0 | linux/x86_64 | ocaml-base-compiler.5.3.0 | pinned(https://github.com/ml-in-barcelona/server-reason-react/releases/download/0.3.1/server-reason-react-0.3.1.tbz)
# path                 ~/.opam/5.3/.opam-switch/build/server-reason-react.0.3.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p server-reason-react -j 255 @install
# exit-code            1
# env-file             ~/.opam/log/server-reason-react-7-127efc.env
# output-file          ~/.opam/log/server-reason-react-7-127efc.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I packages/melange.js/.js.objs/byte -I /home/opam/.opam/5.3/lib/lwt -I /home/opam/.opam/5.3/lib/ocaml/str -I /home/opam/.opam/5.3/lib/quickjs -cmi-file packages/melange.js/.js.objs/byte/js.cmi -no-alias-deps -o packages/melange.js/.js.objs/byte/js.cmo -c -impl packages/melange.js/Js.pp.ml)
# File "packages/melange.js/Js.ml", line 501, characters 12-20:
# 501 |     | Error (_, msg) -> raise (Invalid_argument msg)
#                   ^^^^^^^^
# Error: This pattern matches values of type "'a * 'b"
#        but a pattern was expected which matches values of type
#          "Quickjs.RegExp.compile_error"
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlopt.opt -w -40 -g -I packages/melange.js/.js.objs/byte -I packages/melange.js/.js.objs/native -I /home/opam/.opam/5.3/lib/lwt -I /home/opam/.opam/5.3/lib/ocaml/str -I /home/opam/.opam/5.3/lib/quickjs -cmi-file packages/melange.js/.js.objs/byte/js.cmi -no-alias-deps -o packages/melange.js/.js.objs/native/js.cmx -c -impl packages/melange.js/Js.pp.ml)
# File "packages/melange.js/Js.ml", line 501, characters 12-20:
# 501 |     | Error (_, msg) -> raise (Invalid_argument msg)
#                   ^^^^^^^^
# Error: This pattern matches values of type "'a * 'b"
#        but a pattern was expected which matches values of type
#          "Quickjs.RegExp.compile_error"
[...]
```
Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

CI is now down to Failed to get sources of base.v0.16.4: curl failed (and a single opam-2.0 failure).

@jmid jmid merged commit f238b7d into ocaml:master Dec 8, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants