CUST-4675 added 'Skype for Consumer' and 'Skype for Business' to conferencing providers.

[samuelpx]

The SDK was failing to validate the responses due to these missing in the ConferencingProvider model.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

[playerzero-ai]

Pull Request Summary

• Conferencing Provider Support: Added "Skype for Consumer" and "Skype for Business" as options in the conferencing provider list, enhancing user experience by offering more popular choices.

• Error Handling: Introduced explicit exceptions for unsupported conferencing providers in event creation and update methods. This ensures clear error messages when unsupported providers are used, guiding developers to use the new enum for these cases.

• Developer Guidance: Improved developer experience by providing better error handling and guidance, reducing confusion and potential errors when dealing with conferencing details in events.

Functional Tests

• Verify that 'Skype for Consumer' appears as an option in the conferencing providers list.
• Verify that 'Skype for Business' appears as an option in the conferencing providers list.
• Test that a user can successfully select 'Skype for Consumer' as their conferencing provider and that it integrates correctly with the scheduling system.
• Test that a user can successfully select 'Skype for Business' as their conferencing provider and that it integrates correctly with the scheduling system.
• Ensure that the UI correctly displays the selected conferencing provider ('Skype for Consumer' or 'Skype for Business') in the user's settings or meeting details.
• Check that switching between different conferencing providers, including the newly added Skype options, updates the system and UI without errors.

Files Changed

File Name	Summary
src/main/kotlin/com/nylas/models/CreateEventRequest.kt	Added explicit exceptions for unsupported conferencing providers (Skype for Consumer, Skype for Business) in the CreateEventManualConferencingProvider conversion method to improve error handling and developer guidance.
src/main/kotlin/com/nylas/models/UpdateEventRequest.kt	Added explicit exceptions for unsupported conferencing providers in the fromConferencingProvider method to enforce use of the new enum and improve code clarity and robustness.
src/main/kotlin/com/nylas/models/ConferencingProvider.kt	Added support for "Skype for Consumer" and "Skype for Business" as conferencing provider options to expand available choices.

View more in PlayerZero
updated: Aug 14 @ 12:55 PM UTC

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.75%. Comparing base (5ccd0b7) to head (719e9b7).

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #294   +/-   ##
=========================================
  Coverage     81.75%   81.75%           
  Complexity      344      344           
=========================================
  Files            36       36           
  Lines          1014     1014           
  Branches         88       88           
=========================================
  Hits            829      829           
  Misses          132      132           
  Partials         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AaronDDM]

Let's change this to "Fixed" - this is a bug apparently