Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 6, 2025

No description provided.

@bsipocz bsipocz added the infrastructure Issues relevant to infrasructure, rather than content label Nov 6, 2025
@bsipocz bsipocz force-pushed the ENH_switch_to_JB2 branch 2 times, most recently from c4ac7a7 to 627aafd Compare November 6, 2025 16:35
@bsipocz bsipocz closed this Nov 7, 2025
@bsipocz bsipocz reopened this Nov 7, 2025
@bsipocz
Copy link
Member Author

bsipocz commented Nov 7, 2025

Well, apparently having the make file would make sense so we run the same in conda and in tox.

OTOH, do we really still need conda, or should nuke it and redo env management in pixi instead?

@rossbar
Copy link
Collaborator

rossbar commented Nov 7, 2025

OTOH, do we really still need conda, or should nuke it and redo env management in pixi instead?

👍 this is my thought too - especially since the environment resolution takes longer than the notebook execution 🙃 . There exists tooling for this exact problem now so let's transition to it.

I'd propose to remove the conda job in this PR then re-do/beef up CI after updating tooling.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 7, 2025

We're still seeing issues with the preview, so this should not be merged until that is solved.

@stefanv
Copy link
Contributor

stefanv commented Nov 8, 2025

We're still seeing issues with the preview, so this should not be merged until that is solved.

How do you pass the BASE_URL to tox? It may need something like passenv.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 8, 2025

I'm not sure what we consider blocking for this PR, there are some issues I see. For anything that is a follow-up we may want to open an issue so we don't forget them.

  • build time on CircleCI is significantly longer than it was with JB1. I could easily consider this as a follow-up though.
  • cleaning up build errors and warnings -- currently we don't run with strict (and we didn't run with a similar manner as we were not failing JB1 builds with these broken links either)
  • deployment not to a gh-pages branch -- this could probably be done as a follow-up, too and now just use the file we have. (I need to make my other repos consistent, too so can do this repo along with those).

@stefanv
Copy link
Contributor

stefanv commented Nov 8, 2025

  • build time on CircleCI is significantly longer than it was with JB1. I could easily consider this as a follow-up though.

Do you have a sense of why this is? Parallel execution of notebooks, setup time, etc.?

@stefanv
Copy link
Contributor

stefanv commented Nov 8, 2025

Last build failed with timeout :/

@bsipocz
Copy link
Member Author

bsipocz commented Nov 8, 2025

build time on CircleCI is significantly longer than it was with JB1. I could easily consider this as a follow-up though.

Do you have a sense of why this is? Parallel execution of notebooks, setup time, etc.?

Unfortunately I don't have any good guesses. My experience with the IRSA notebooks were that the build is faster, but in reality those are the worst benchmarks ever as all of them are about querying data on remote servers and that has a genuine huge scatter in runtime (and gazillion timeouts that are due to the server side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues relevant to infrasructure, rather than content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants