fix: adding additional validation for scoped packages that begin with one or more .
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmam
force-pushed
the
add-validation-scoped-periods
branch
from
1180a53 to
976de15
Compare
wraithgar
approved these changes
Jun 5, 2025
Merged
shmam
pushed a commit
that referenced
this pull request
Jun 5, 2025
🤖 I have created a release *beep* *boop* --- ## [6.0.1](v6.0.0...v6.0.1) (2025-06-05) ### Bug Fixes * [`68a5c0e`](68a5c0e) [#136](#136) adding validation for scoped packages that begin with one or more periods (@shmam) ### Chores * [`99ced75`](99ced75) [#136](#136) template-oss fixes (@shmam) * [`c45bc37`](c45bc37) [#134](#134) bump @npmcli/template-oss from 4.23.3 to 4.24.3 (#134) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional validation and tests to cover scoped packages to enforce rule:
Examples include
@npm/..@npm/.@npm/.somethingReferences
@explodingcabbage/..is a valid package name #135