Skip to content

test: merge knownGlobals in common #54915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avivkeller wants to merge 1 commit into from
Closed

test: merge knownGlobals in common #54915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 13 additions & 90 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,96 +299,19 @@ function platformTimeout(ms) {
}

let knownGlobals = [
AbortController,
atob,
btoa,
clearImmediate,
clearInterval,
clearTimeout,
global,
setImmediate,
setInterval,
setTimeout,
queueMicrotask,
];

if (global.gc) {
knownGlobals.push(global.gc);
}

if (global.navigator) {
knownGlobals.push(global.navigator);
}

if (global.Navigator) {
knownGlobals.push(global.Navigator);
}

if (global.Performance) {
knownGlobals.push(global.Performance);
}
if (global.performance) {
knownGlobals.push(global.performance);
}
if (global.PerformanceMark) {
knownGlobals.push(global.PerformanceMark);
}
if (global.PerformanceMeasure) {
knownGlobals.push(global.PerformanceMeasure);
}

// TODO(@ethan-arrowood): Similar to previous checks, this can be temporary
// until v16.x is EOL. Once all supported versions have structuredClone we
// can add this to the list above instead.
if (global.structuredClone) {
knownGlobals.push(global.structuredClone);
}

if (global.EventSource) {
knownGlobals.push(EventSource);
}

if (global.fetch) {
knownGlobals.push(fetch);
}
if (hasCrypto && global.crypto) {
knownGlobals.push(global.crypto);
knownGlobals.push(global.Crypto);
knownGlobals.push(global.CryptoKey);
knownGlobals.push(global.SubtleCrypto);
}
if (global.CustomEvent) {
knownGlobals.push(global.CustomEvent);
}
if (global.ReadableStream) {
knownGlobals.push(
global.ReadableStream,
global.ReadableStreamDefaultReader,
global.ReadableStreamBYOBReader,
global.ReadableStreamBYOBRequest,
global.ReadableByteStreamController,
global.ReadableStreamDefaultController,
global.TransformStream,
global.TransformStreamDefaultController,
global.WritableStream,
global.WritableStreamDefaultWriter,
global.WritableStreamDefaultController,
global.ByteLengthQueuingStrategy,
global.CountQueuingStrategy,
global.TextEncoderStream,
global.TextDecoderStream,
global.CompressionStream,
global.DecompressionStream,
);
}

if (global.Storage) {
knownGlobals.push(
global.localStorage,
global.sessionStorage,
global.Storage,
);
}
AbortController, atob, btoa, clearImmediate, clearInterval, clearTimeout, global,
setImmediate, setInterval, setTimeout, queueMicrotask, structuredClone, global.gc,
global.navigator, global.Navigator, global.Performance, global.performance,
global.PerformanceMeasure, global.EventSource, global.fetch, global.PerformanceMark,
global.ReadableStream, global.ReadableStreamDefaultReader, global.ReadableStreamBYOBReader,
global.ReadableStreamBYOBRequest, global.ReadableByteStreamController, global.TransformStream,
global.ReadableStreamDefaultController, global.TransformStreamDefaultController,
global.WritableStream, global.WritableStreamDefaultWriter, global.WritableStreamDefaultController,
global.ByteLengthQueuingStrategy, global.CountQueuingStrategy, global.TextEncoderStream,
global.TextDecoderStream, global.CompressionStream, global.DecompressionStream, global.crypto,
global.Crypto, global.CryptoKey, global.SubtleCrypto, global.CustomEvent, global.Storage,
global.localStorage, global.sessionStorage,
].filter((g) => g !== undefined);

function allowGlobals(...allowlist) {
knownGlobals = knownGlobals.concat(allowlist);
Expand Down