package.json: Upgrade node-gyp to support Python >= v3.12 #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides compatibility with Python 3.12, 3.13, and later. https://github.com/nodejs/node-gyp/releases * nodejs/node-gyp#2869 * https://devguide.python.org/versions Related to: * nodejs#932
cclauss
added a commit
to cclauss/nan
that referenced
this pull request
Feb 8, 2025
These failing tests will be fixed by * nodejs#985
This was referenced Feb 8, 2025
cclauss
added a commit
to cclauss/nan
that referenced
this pull request
Feb 9, 2025
Collaborator
|
Looking at the test output from this, there are a lot of failures on ancient versions. Am I correct in assuming that this is expected. The reason for keeping as old a node-gyp as possible has been to enable testing on these ancient versions. I am prepared to drop them from testing if necessary. |
Contributor
Author
|
We should not actively encourage building software on unsupported versions of Node.js, node-gyp, or Python. We could focus GitHub Actions on testing the versions that actually pass on that CI. We could retool the AppVeyor tests to cover only the old and ugly versions on |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nodejs/node-gyp?tab=readme-ov-file#installation says
Important
Python >= v3.12 requires
node-gyp>= v10Fixes: #986
package.json:Provides compatibility with Python 3.12, 3.13, and later.
https://github.com/nodejs/node-gyp/releases
Related to:
@mkrufky Your review, please.