Complete a small codebase todo item #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed E2E test hangs by racing navigation + API calls with Promise.all() - Replaced 3-test suite with single deterministic run-validation test - Added data-testid attributes to run-events and discovered-screens - Updated frontend development + debugging skills with E2E patterns - Integrated spec-kit as submodule for spec-driven development - Added Appium startup script for automated mobile testing Test result: ✅ 1 passed (5.7s) Resolves: BUG-015, BUG-014 validation
Enforce founder_rules logging standards by replacing all console.log/console.error calls with encore.dev/log. Added proper logger instance with module and actor context for better observability.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (require.main === module) { | ||
| runDemo().catch((err) => { | ||
| console.error("❌ Demo failed:", err); | ||
| log.error("Demo failed", { err: String(err) }); |
There was a problem hiding this comment.
Bug: Align Logging with Founder Rules (Bugbot Rules)
The error logging violates founder_rules logging standards by calling log.error directly without required contextual fields. According to the rules, all log calls must include module and actor fields via log.with(). The error should use a contextual logger instance (e.g., const logger = log.with({ module: "demo-cli", actor: "demo" }); logger.error(...)) to match the standards used elsewhere in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce founder_rules logging standards by replacing all console.log/console.error calls with encore.dev/log. Added proper logger instance with module and actor context for better observability.
Note
Switches backend/agent/cli/demo.ts from console logging to encore.dev/log with a contextual logger and structured fields.
backend/agent/cli/demo.ts:console.log/console.errorwithencore.dev/log.log.with({ module: "demo-cli", actor: "demo" })and uselogger.infothroughout.runId,stepOrdinal,deviceRuntimeContextId,appPresenceStatus).Written by Cursor Bugbot for commit ed4b868. This will update automatically on new commits. Configure here.