-
Notifications
You must be signed in to change notification settings - Fork 18
Switch from zenodo.json to CITATION.cff, add contributors #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 95.15% 95.38% +0.22%
==========================================
Files 28 28
Lines 2933 2948 +15
==========================================
+ Hits 2791 2812 +21
+ Misses 142 136 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It's nice of you to include me in the citation! My info there is right. But I also modified exactly 2 lines of code so I don't think you need to credit me. I'll leave that up to you. |
|
Thanks for putting this together @effigies ! It looks great to me. |
| license: MIT | ||
| type: software | ||
| url: https://github.com/nipy/nitransforms/ | ||
| version: 24.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this overriden by releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets overridden by Zenodo, but we should probably make updating it part of the release process so it's up-to-date in git and source archives.
We haven't been updating contributors properly. I think it will generally be easier to have people add themselves to CITATION.cff when they do contribute.
There isn't a distinction between creators and contributors, so that's one downside here.
Please confirm your ORCIDs, names and affiliations: @bpinsard @jbanusco @mvdoc @jmarabotto @feilong @Shotgunosine @shnizzedy @coryshain