fix: Properly quote file paths with spaces #3739
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to ensure that we handle files/directories with spaces correctly. Unfortunately, there are a number of interfaces that separately handle the problem by including quotes in their
argstrs, some with single quotes, some with double quotes. We have to assume that there are downstream tools that do the same.This therefore narrowly addresses the case where the
argstris a plain-as-dirt%sand the trait is either aFile/Directoryor a list of such things.Fixes #3604.
List of changes proposed in this PR (pull-request)
Unrelated changes that I don't want to open separate PRs for
isinstancecheck had been copied from the previousifblock but not updated to match the new context.NO_ETto the tox environments to improve startup times for testing.