MAINT: Require Python >= 3.5, purge Python 2 compatibility #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
maint/purge_python2
branch
2 times, most recently
from
7c437af to
930ee6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 94 94
Lines 12018 11886 -132
Branches 2136 2119 -17
==========================================
- Hits 10821 10702 -119
+ Misses 851 840 -11
+ Partials 346 344 -2
Continue to review full report at Codecov.
|
effigies
force-pushed
the
maint/purge_python2
branch
3 times, most recently
from
647c329 to
676be6b
Compare
effigies
commented
Aug 12, 2019
Member
Author
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
Still need to update docs one more time.
A review would be greatly appreciated.
effigies
force-pushed
the
maint/purge_python2
branch
from
6a4f727 to
814727a
Compare
effigies
force-pushed
the
maint/purge_python2
branch
from
80704a0 to
d6442c1
Compare
Closed
Member
Author
|
Taking the plunge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
assert_warnsdoes not work properly with multiple warnings being emitted until then; we've been somehow missing this edge case by checking minimum versions on Py2 only)nibabel.externals.sixaltogether, along with all imports fromsixnibabel.py3ktonumpy.compat.py3k. They don't seem to be dropping it when dropping Python 2 support so it seems safe to rely on it.grep -E -rIi 'py(thon)? ?[23]' nibabel | grep '\.py:'were removed.pkg_infowill be handled in MAINT: Manage versioning with versioneer #786.sixpy3kfrom __future__PY2/PY3tags indicating compatibility hacks