Skip to content

Conversation

@tsalo
Copy link
Contributor

@tsalo tsalo commented Nov 8, 2024

I am currently processing multi-echo BOLD data with both AP and PA acquisitions through fMRIPrep, and I noticed that the T2starmap outputs didn't include the direction entity, so I was only getting one of the two directions for each acquisition.

I also made task optional for T2starmap, but I can revert that.

Also make task optional.
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.44%. Comparing base (87319fe) to head (359c05c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   71.44%   71.44%           
=======================================
  Files          87       87           
  Lines        8402     8402           
  Branches      829      829           
=======================================
  Hits         6003     6003           
  Misses       2394     2394           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit cd633c9 into nipreps:master Nov 8, 2024
22 checks passed
@tsalo tsalo deleted the t2starmap-entities branch November 10, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants