Upgrade AsyncGenerator to 0.13.1 #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
changed the title
fredericDelaporte
force-pushed
the
AsyncUpgrade
branch
from
9cca877 to
a7e13d0
Compare
fredericDelaporte
changed the title
fredericDelaporte
changed the title
hazzik
previously approved these changes
Jan 23, 2019
hazzik
approved these changes
Jan 23, 2019
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHibernate currently used a 0.8 version having received many backports of fixes from newer versions.
I think we should upgrade it to latest version instead of going on relying on backports in case of new needs / new unsupported patterns used in NHibernate.
This update also refines the cases where generated async code is guarded by
try catchclauses. (Some are removed, other are added.)By the way, I let the .DotSettings file get updated by Rider here: it does no more remove the property we were not willing to let it remove.