Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 19, 2025

☑️ Resolves

I'm very unsure with the approach in this PR:

  1. It indirectly overrides <NcListItem> styles...
    • Should it be internally modified in the NcListItem based on isInFormBox instead?
    • Should it be just a new component like McFormListBoxItem?
  2. Should it be in any way related to the NcFormBox?
    • We can make it optionally ul and override styles there instead of a new container

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 9.3.0 milestone Nov 19, 2025
@ShGKme ShGKme requested review from kra-mo and susnux November 19, 2025 15:30
@ShGKme ShGKme self-assigned this Nov 19, 2025
@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.11%. Comparing base (8e6c2a6) to head (1957223).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7889   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files         100      100           
  Lines        3170     3170           
  Branches      872      872           
=======================================
  Hits         1652     1652           
  Misses       1271     1271           
  Partials      247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux modified the milestones: 9.3.0, 9.3.1 Nov 20, 2025
@kra-mo
Copy link
Member

kra-mo commented Nov 20, 2025

So that I understand: Currently, there is no dedicated "list" component, only the standard <ul> tag, correct?

And the only thing this does is add separators between list items, correct?

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 20, 2025

So that I understand: Currently, there is no dedicated "list" component, only the standard <ul> tag, correct?

No, this PR adds a new dedicated NcFormListBox component as an alternative to NcFormBox for lists.

And the only thing this does is add separators between list items, correct?

No, it also adjusts the padding of the existing NcListItem to match the other form element labels.

@kra-mo
Copy link
Member

kra-mo commented Nov 20, 2025

Ok, well regarding #7900 (comment), I'm not sure some of these should even be list items then…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants