[stable8] fix(NcActions): handle expensive height computation by popover library #7865
+2
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
Antreesy,
ShGKme,
jancborchardt and
susnux
backportbot
bot
added
3. to review
- `autoBoundaryMaxSize` lets floating vue resize the popper inner container to the available size Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
backport/7778/stable8
branch
from
95b684d to
f349117
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #7865 +/- ##
========================================
Coverage 45.08% 45.08%
========================================
Files 191 191
Lines 4749 4749
Branches 1169 1226 +57
========================================
Hits 2141 2141
+ Misses 2514 2512 -2
- Partials 94 96 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… library Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
reviewed
Nov 15, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
See deployed page.
Although option is present, it works a bit worse in comparison with Vue3 branch, popper is overflowing the document.body (probably because of 4px padding added). Haven't tested in apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7778
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.