-
Notifications
You must be signed in to change notification settings - Fork 94
feat(NcModal): expose initialFocus prop for focus-trap options
#7587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c834c99 to
17df305
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
17df305 to
8afa991
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7587 +/- ##
=======================================
Coverage 52.20% 52.20%
=======================================
Files 101 101
Lines 3174 3174
Branches 871 872 +1
=======================================
Hits 1657 1657
Misses 1271 1271
Partials 246 246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I forgot about that PR🪦 Shall we get it in? |
|
Was it for the translation dialog in chat? |
|
Yes, in general it fits for any dialog that does not need to have an initial focus on the child element |
With a small CSS fix, and by using available props and events we can make Would it also work for you? |
Depends on how it changes current default behaviour, and what app developers should do to implement it. I'd take a look =) |
☑️ Resolves
initialFocusandsetReturnFocusto NcModal and NcDialog consumers🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable