Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 17, 2025

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After (EN)
image image
DE UA FR AR
image image image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 9.0.0-rc.10 milestone Sep 17, 2025
@ShGKme ShGKme requested a review from a team September 17, 2025 11:29
@ShGKme ShGKme self-assigned this Sep 17, 2025
@ShGKme ShGKme added bug Something isn't working 2. developing Work in progress design Design, UX, interface and interaction design feature: timezone-picker labels Sep 17, 2025
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice @ShGKme ! Is it possible to cut the " Time" text, as it is very repeated.

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 17, 2025

Very very nice @ShGKme ! Is it possible to cut the " Time" text, as it is very repeated.

In a general case — no. It is a browser-provided timezone string, and it is different for every language. For example, "heure : " in French or "час:" in Ukrainian. It is already a short variant.

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 17, 2025

Also, every part (except for timezoneID like "Europe/Berlin") adds ~50ms component init time 😶

  • Shot name "Germany Time" - +50ms
  • Offset value "GMT+1" - +50ms
  • Local current time "10:10 PM" - +50ms
  • Actual offset for sorting - +50ms

So removing any part makes the component faster :D

Optimised as much as possible to have the init happen only once and only when needed

@jancborchardt
Copy link
Contributor

Also, every part (except for timezoneID like "Europe/Berlin") adds ~50ms component init time 😶

Oof :O bummer, would be really nice to stay under 100ms.

But if we cut e.g. the offset value, and the technical name, then it's a bit less nicely usable and searchable.

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 17, 2025

@jancborchardt Maybe this would be useful — examples of available formats in different languages:

Link

@jancborchardt
Copy link
Contributor

@ShGKme bit of a mess … in English, shortGeneric is a bit better, but in German that’s quite bad. (Just showing "MEZ" a bunch.)

If we just go for one, is it possible to say that e.g. in English and others we use "shortGeneric", and in German we use "Timezone ID"? Sorry to overcomplicate it, but the system doesn’t seem to make it simple. :\

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 17, 2025

is it possible

Yes, but the question will be - for which languages do we want an exception

and in German we use "Timezone ID"

ID is a technical non-translated value. Maybe at least a long name? Or City + Short?

MEZ (Berlin)

@jancborchardt
Copy link
Contributor

@ShGKme but if we use shortGeneric + city, we still use 2*50ms, right? So maybe it's fine to just go with your pull request as is, and then iterating based off that if we see specific issues?

@kra-mo
Copy link
Member

kra-mo commented Sep 18, 2025

From the visual side, I like this, but what belongs to what can be a bit confusing. Could separators be added between the items? Or alternatively just the top/bottom padding increased (although that compromises on information density).

@kra-mo
Copy link
Member

kra-mo commented Sep 18, 2025

although that compromises on information density

On second thought, and after playing with it a bit, just bumping the top/bottom padding might be the better option anyway as for separators, we would need to increase the padding slightly too and they actually introduce a bit of noise themselves.

@kra-mo
Copy link
Member

kra-mo commented Sep 18, 2025

Separators only for reference

image

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 26, 2025

From the visual side, I like this, but what belongs to what can be a bit confusing. Could separators be added between the items? Or alternatively just the top/bottom padding increased (although that compromises on information density).

Technically - yes, but I'd avoid such changes in this PR.

We have this style in popovers list items in all the selecting (incl. tag select, user select), action menus, contenteditable autocomplete and etc.

If we want to change the style of the items, I'd insist on changing them in the design, not in a timezone picker specifically...

Here I can propose to increase the internal block padding.

@kra-mo
Copy link
Member

kra-mo commented Sep 29, 2025

Here I can propose to increase the internal block padding.

Yes, I can agree with that

@Antreesy Antreesy modified the milestones: 9.0.0-rc.10, 9.0.1 Oct 1, 2025
@susnux susnux modified the milestones: 9.0.1, 9.0.2 Oct 6, 2025
@susnux susnux removed this from the 9.0.2 milestone Oct 14, 2025
@jancborchardt jancborchardt self-requested a review December 1, 2025 12:54
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am also good with just a little added padding. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug Something isn't working design Design, UX, interface and interaction design feature: timezone-picker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants