-
Notifications
You must be signed in to change notification settings - Fork 94
[DRAFT] fix(NcTimezonePicker): new design with l10n #7523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very nice @ShGKme ! Is it possible to cut the " Time" text, as it is very repeated.
In a general case — no. It is a browser-provided timezone string, and it is different for every language. For example, "heure : " in French or "час:" in Ukrainian. It is already a short variant. |
|
Also, every part (except for timezoneID like "Europe/Berlin") adds ~50ms component init time 😶
So removing any part makes the component faster :D Optimised as much as possible to have the init happen only once and only when needed |
Oof :O bummer, would be really nice to stay under 100ms. But if we cut e.g. the offset value, and the technical name, then it's a bit less nicely usable and searchable. |
|
@jancborchardt Maybe this would be useful — examples of available formats in different languages: |
|
@ShGKme bit of a mess … in English, If we just go for one, is it possible to say that e.g. in English and others we use "shortGeneric", and in German we use "Timezone ID"? Sorry to overcomplicate it, but the system doesn’t seem to make it simple. :\ |
Yes, but the question will be - for which languages do we want an exception
ID is a technical non-translated value. Maybe at least a long name? Or City + Short?
|
|
@ShGKme but if we use shortGeneric + city, we still use 2*50ms, right? So maybe it's fine to just go with your pull request as is, and then iterating based off that if we see specific issues? |
|
From the visual side, I like this, but what belongs to what can be a bit confusing. Could separators be added between the items? Or alternatively just the top/bottom padding increased (although that compromises on information density). |
On second thought, and after playing with it a bit, just bumping the top/bottom padding might be the better option anyway as for separators, we would need to increase the padding slightly too and they actually introduce a bit of noise themselves. |
Technically - yes, but I'd avoid such changes in this PR. We have this style in popovers list items in all the selecting (incl. tag select, user select), action menus, contenteditable autocomplete and etc. If we want to change the style of the items, I'd insist on changing them in the design, not in a timezone picker specifically... Here I can propose to increase the internal block padding. |
Yes, I can agree with that |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am also good with just a little added padding. :)

☑️ Resolves
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable