-
Notifications
You must be signed in to change notification settings - Fork 94
ci: sync stable branch translations #7247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Isn't it supposed to be covered by the bot ( |
I did not find any information on this 🤔 |
|
But this is only for apps, we do not use the app translations but the native transifex integration |
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is only for apps, we do not use the app translations but the native transifex integration
That's correct, and iirc, the sync simply has a branch list on the config, but i never tried it.
|
@nickvergessen yes you can add branches for Transifex, but if I understood that correctly it will create new resources for translators. That is not what we want - no? |
Does it mean we need it globally in |
|
We barely add and remove language strings here, so I think for now I will test if simply adding the branch works and does not create a new resource, we'll do that or manually copy the language files one time afterwards |
How many libraries use translations? |
Only main branch will be localized by Transifex. To also update the stable branch with translations we need to synchronize them. This actions does following: - clone both branches - combine po files from both branches for each language - check the stable branch po template which messages are needed - copy needed messaged from the combined po file (use the main if the translation differ) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
At least 4
At least 2 |
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is immediate need to fix this due to customer demand, please let this sit until after my vacation, so we can first try if it works with transifex directly.
|
So after checking it seems the inline feature of Transifex is focusing on feature Pull requests, not on "stable branches". So copying them to/from main sounds like the best idea. Whether we need to merge them or not is another question. We can give translation folders instead of files, so each branch could have their own files: So we could have a cron action that copies the PO files from stable to main and the POT from main to the stables? |
☑️ Resolves
Only main branch will be localized by Transifex.
To also update the stable branch with translations we need to synchronize them.
This actions does following:
This works locally, but I am not sure if the msgcat and msgmerge commands are installed on the runner.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable