Fix type-checking of test/ directories #519
Draft
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript files in
test/directories (outsidesrc/) were not being type-checked because they weren't included in packagetsconfig.jsonfiles, and tsup only type-checks files in its build entries.Changes
tsconfig.json updates
Updated
tsconfig.jsonfor packages withtest/directories:"test"toinclude"test"toinclude"test"toinclude, excluded"test/types"(contains tsd type-testing files with intentional errors)package.json updates
Added explicit type-checking scripts to ensure test files are type-checked independently of tsup:
"test:ci:types": "tsc --noEmit"script that runs as part oftest:ci:*"test:types": "tsc --noEmit"and"test:vitest": "vitest run"scripts, updated test commands to run both"test:ci:types": "tsc --noEmit"script that runs as part oftest:ci:*Notes
src/test/(cache, dev-utils) already covered by"src"includetsc --noEmitcommands as part of the test suite, not relying on tsup's build processOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.